Fix Trigger DAG w/config origin url #29212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
(cherry picked from commit 7315d6f)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit 7315d6f)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29197
This PR fixes the origin url for the Trigger DAG w/config web page, where currently, it redirects to the origin endpoint with the param dag_id, but for some origins, this lead to a error 400.
For example, when we navigate to the Trigger DAG w/config page from the endpoint tasks, the origin url will be
/tasks?dag_id=<dag_id>without thetask_id, theexecution_dateand themap_index, so when it redirect to this origin url, we getBad Request Invalid datetime: None. To fix this problem, I redirect to the origin endpoint with all the origin params and I adddag_idif it doesn't exist in the origin params.