Fix dag run trigger with a note. #29228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedantlodha
force-pushed
the
issue-28825
branch
from
1c41a03
to
ca7bdf8
Compare
ephraimbuddy
approved these changes
Jan 30, 2023
vedantlodha
force-pushed
the
issue-28825
branch
4 times, most recently
from
b72511f
to
0c671f5
Compare
There was a problem hiding this comment.
@vedantlodha, can you add test coverage for this as well? Thanks.
Currently, triggering dag run with note gives 400. This PR fixes it. Closes: apache#28825
vedantlodha
force-pushed
the
issue-28825
branch
from
0c671f5
to
62034b8
Compare
|
Thanks for the suggestion @jedcunningham. Updated the test with latest commit. |
jedcunningham
approved these changes
Feb 1, 2023
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows dag run trigger with a note, which, at the moment gives a 400.
Closes: #28825
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.