-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grid logs for large logs #29390
Fix grid logs for large logs #29390
Conversation
Thanks Brent for this fix. 'Full Logs' impacts only how we request logs to the rest API. Most of the time, without requesting full logs, reading by chunk/tail will be enough to avoid most of UI issues due to large file. Unfortunatly if a log chunk contains a really really long line we can still have a huge chunk, Brent sample shows 1 line of log that is 5Mb of text by itself and this can cause rendering + performance issues. I agree that the wording between these two elements are a bit confusing.
|
There is a |
Yep I agree, this isn't something I realised when implementing it. We can remove it for now, and add it back when we actually have support for it. |
* slice extra long file lines, remove full content * add warning if logs are truncated * Add warning for `.split()` errors * remove extraneous useTaskLog change * remove Show Full Content checkbox * remove extraneous console.error (cherry picked from commit 1ed0802)
If a task instance an very large log file, the UI would have difficulty rendering it. This PR fixes this on the UI side but truncating lines in the logs to less than 1 million characters and including a warning to the user.
Example DAG:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.