-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't display empty rendered attrs in Task Instance Details page #29545
Conversation
Closes: apache#29515 The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance. This PR changes the attributes displayed on the page only if they have non-empty values generally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this would hide the attribute for all falsy
values. (0, "", [], etc...). Maybe we only want to skip when the value is actually None ?
Yes, which is actually |
I think it's ok like this. Attribute are taken from (I was concerned that some attributes could be of different types, like boolean or int for instance, but it doesn't seem like so) |
) Closes: #29515 The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance. This PR changes the attributes displayed on the page only if they have non-empty values generally. (cherry picked from commit f2f6099)
) Closes: #29515 The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance. This PR changes the attributes displayed on the page only if they have non-empty values generally. (cherry picked from commit f2f6099)
Closes: #29515
The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e.
doc
,doc_json
,doc_md
,doc_rst
, anddoc_yaml
). This clutters the page with less useful information for the task instance.This PR changes the attributes displayed on the page only if they have non-emptyvalues generally.
Current Task Instance Details with no doc attribute provided
New Task Instance Details with no doc or other special rendered attributes
Current Task Instance Details with
bash_command
and onlydoc_md
providedThere are other special-rendered like
sql
andhql
but let's use aBashOperator
as an example.New Task Instance Details with
bash_command
and onlydoc_md
provided