Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit importlib-metadata backport to < 5.0.0 #29924

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 5, 2023

The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0.

The fix in celery: celery/celery#7785


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until
Celery 5.3.0 gets released (it is pre-release/beta now) we should
workaround the problem by limiting importlib-metadata to < 5.0.0.
@potiuk potiuk changed the title Limit importlib-metadata backwport to < 5.0.0 Limit importlib-metadata backport to < 5.0.0 Mar 5, 2023
@eladkal eladkal merged commit 4ea457a into apache:main Mar 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Mar 8, 2023
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until
Celery 5.3.0 gets released (it is pre-release/beta now) we should
workaround the problem by limiting importlib-metadata to < 5.0.0.

(cherry picked from commit 4ea457a)
@potiuk potiuk added this to the Airflow 2.5.2 milestone Mar 9, 2023
ephraimbuddy pushed a commit that referenced this pull request Mar 9, 2023
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until
Celery 5.3.0 gets released (it is pre-release/beta now) we should
workaround the problem by limiting importlib-metadata to < 5.0.0.

(cherry picked from commit 4ea457a)
ephraimbuddy pushed a commit that referenced this pull request Mar 10, 2023
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until
Celery 5.3.0 gets released (it is pre-release/beta now) we should
workaround the problem by limiting importlib-metadata to < 5.0.0.

(cherry picked from commit 4ea457a)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 10, 2023
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 13, 2023
The original apache#29924 fix containt both > and < condition on
Python 3.9 thus the limit did not apply to Python 3.9
ephraimbuddy pushed a commit that referenced this pull request Mar 13, 2023
The original #29924 fix containt both > and < condition on
Python 3.9 thus the limit did not apply to Python 3.9
ephraimbuddy pushed a commit that referenced this pull request Mar 13, 2023
The original #29924 fix containt both > and < condition on
Python 3.9 thus the limit did not apply to Python 3.9

(cherry picked from commit 6e2bdcf)
@ephraimbuddy ephraimbuddy added type:misc/internal Changelog: Misc changes that should appear in change log and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Mar 13, 2023
@potiuk potiuk deleted the fix-importlib-metadata-breaking-celery-import branch March 22, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants