-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit importlib-metadata backport to < 5.0.0 #29924
Merged
eladkal
merged 1 commit into
apache:main
from
potiuk:fix-importlib-metadata-breaking-celery-import
Mar 5, 2023
Merged
Limit importlib-metadata backport to < 5.0.0 #29924
eladkal
merged 1 commit into
apache:main
from
potiuk:fix-importlib-metadata-breaking-celery-import
Mar 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0.
potiuk
changed the title
Limit importlib-metadata backwport to < 5.0.0
Limit importlib-metadata backport to < 5.0.0
Mar 5, 2023
eladkal
approved these changes
Mar 5, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 8, 2023
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0. (cherry picked from commit 4ea457a)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 9, 2023
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0. (cherry picked from commit 4ea457a)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 10, 2023
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0. (cherry picked from commit 4ea457a)
ephraimbuddy
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Mar 10, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 13, 2023
The original apache#29924 fix containt both > and < condition on Python 3.9 thus the limit did not apply to Python 3.9
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 13, 2023
The original #29924 fix containt both > and < condition on Python 3.9 thus the limit did not apply to Python 3.9
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 13, 2023
ephraimbuddy
added
type:misc/internal
Changelog: Misc changes that should appear in change log
and removed
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
labels
Mar 13, 2023
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0.
The fix in celery: celery/celery#7785
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.