Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Latest Service Bus Library #31168

Closed
wants to merge 1 commit into from

Conversation

kashifkhan
Copy link

@kashifkhan kashifkhan commented May 9, 2023

This PR updates the azure-service version to 7.10.0. The new version is now using a new all python based AMQP stack, which means uamqp is no longer required and opens up the library overall to be run in a wide variety of architectures, OSes etc. There are some performance improvements when receiving messages from queues & topics.

I had seen an old issue yall had mentioned and this version bump will help with that :)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented May 9, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented May 16, 2023

This PR updates the azure-service version to 7.10.0. The new version is now using a new all python based AMQP stack, which means uamqp is no longer required and opens up the library overall to be run in a wide variety of architectures, OSes etc. There are some performance improvements when receiving messages from queues & topics.

I had seen an old issue yall had mentioned and this version bump will help with that :)

Oh yes It should be just-in-time for the Python 3.11 support #27264 which we waited with for #30067 (going to be merged in the next few days). So it might be very handy (though amqp is currently used by redis - but we are also upgrading this one in #31279 so maybe we can combine all those changes.

@potiuk
Copy link
Member

potiuk commented May 16, 2023

Ah no - that was rabbitmq let me see.

@potiuk
Copy link
Member

potiuk commented May 16, 2023

Ah no - rabbitmq uses amqp not uamqp, so it is unrelated. SO it is cool we are going to get rid of uamqp :)

@kashifkhan
Copy link
Author

Ah no - rabbitmq uses amqp not uamqp, so it is unrelated. SO it is cool we are going to get rid of uamqp :)

yeah 🙂. Both Event Hubs and Service Bus Python clients no longer use uamqp. This should ease up a lot of things for yall like python version upgrades, running on ARM etc.

Glad we could help

@potiuk
Copy link
Member

potiuk commented May 16, 2023

I just rebased this PR to the latest main - it has been 65 commits behind and the error generated was likely coming from that, but I wanted to be absolutely sure.

Just for the future - rebase early, rebase often is a mantra I keep on repeating - it's good to rebase stuff before pushing it to avoid failures that are coming from basing the PR on old commits.

There is also a risk that someone already merged-in PRs tha will make tests start to fail after merging, so rebasing is good to do in almost any case when you push a fix.

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 1, 2023
@github-actions github-actions bot closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:microsoft-azure Azure-related issues stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants