Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest service bus library #38384

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

swathipil
Copy link
Contributor

Following #31168.

PR to update the azure-service version to 7.12.1. The new version is using an all python based AMQP stack, which means uamqp is no longer required and opens up the library overall to be run in a wide variety of architectures, OSes etc. There are some performance improvements when receiving messages from queues & topics. It also includes important bug fixes, including for correct behavior on connection drops, more accurate logging, to address misc. errors/warnings, large message sending/settling.

We saw that you hadn't updated the version in a while and this version will help with an old issue that was seen here, so wanted to bump!


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Mar 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@Taragolis
Copy link
Contributor

This library is not upper bound limited (>=) in requirement and as I could see in the latest constraints use the latest version

azure-servicebus==7.12.1

azure-servicebus==7.12.1

azure-servicebus==7.12.1

azure-servicebus==7.12.1

azure-servicebus==7.12.1

@Taragolis
Copy link
Contributor

But yeah 7.6.0 released Feb 11, 2022 so maybe it is really worthwhile to bump it

@eladkal eladkal merged commit ac50669 into apache:main Mar 23, 2024
89 checks passed
Copy link

boring-cyborg bot commented Mar 23, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants