[AIRFLOW-3973] Commit after each alembic migration #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeshugerman
changed the title
initdb spams log with errors | solution: run each migration in its own transactionIf `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction.
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
=======================================
Coverage 74.44% 74.44%
=======================================
Files 450 450
Lines 28970 28970
=======================================
Hits 21566 21566
Misses 7404 7404Continue to review full report at Codecov.
|
eeshugerman
changed the title
|
Thanks @eeshugerman for figuring this out. |
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction.
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction.
|
@Fokko Could we backport this to v1.10? Is it just a matter of opening a PR to |
|
@eeshugerman please make a PR to the |
|
Just a small update: I think merge PR should go to v1-10-stable - in test we are usually cherry-pick stuff (I have 23 cherry-picked commits to push soon) so better to keep it this way. |
|
A cherry-pick/rebase was required to get a clean PR to I'm assuming the failing |
eeshugerman
changed the title
ashb
pushed a commit
that referenced
this pull request
Jun 9, 2020
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c)
kaxil
pushed a commit
that referenced
this pull request
Jun 14, 2020
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c)
ashb
pushed a commit
that referenced
this pull request
Jun 15, 2020
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c)
kaxil
pushed a commit
that referenced
this pull request
Jun 15, 2020
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c)
dimberman
pushed a commit
that referenced
this pull request
Jun 19, 2020
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c) (cherry picked from commit 5b48a53)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
If `Variable`s are used in DAGs, and Postgres is used for the internal database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the logs with error messages (but does not fail). This commit corrects this by running each migration in a separate transaction. Co-authored-by: Elliott Shugerman <[email protected]> (cherry picked from commit ea95e9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://issues.apache.org/jira/browse/AIRFLOW-3973
Description
If
Variables are used in DAGs, and Postgres is used for the internal database, a fresh$ airflow initdb(or$ airflow resetdb) spams the logs with error messages (but does not fail).This commit corrects this by running each migration in a separate transaction.
See Jira ticket for more details.
I have tested this change with the default SQLite database and, of course, with Postgres.
Tests
No tests included as this is a one line change which adds no functionality whatsoever.