Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3973] Commit after each alembic migration #9182

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[AIRFLOW-3973] Commit after each alembic migration #9182

merged 1 commit into from
Jun 9, 2020

Conversation

eeshugerman
Copy link

If Variables are used in DAGs, and Postgres is used for the internal
database, a fresh $ airflow initdb (or $ airflow resetdb) spams the
logs with error messages (but does not fail).

This commit corrects this by running each migration in a separate
transaction.

If `Variable`s are used in DAGs, and Postgres is used for the internal
database, a fresh `$ airflow initdb` (or `$ airflow resetdb`) spams the
logs with error messages (but does not fail).

This commit corrects this by running each migration in a separate
transaction.
@ashb
Copy link
Member

ashb commented Jun 9, 2020

As mentioned in our other PR https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#airflow-git-branches -- this PR needs to target master, not v1-10-test/stable please.

@ashb ashb added this to the Airflow 1.10.11 milestone Jun 9, 2020
@eeshugerman
Copy link
Author

This is already in master. I'm trying to backport to v1.10. Please see the discussion here: #4797

(Sorry for the confusion, I should have added a note of explanation to these.)

@ashb
Copy link
Member

ashb commented Jun 9, 2020

Ah, we don't need a PR in this case -- just marking the original PR for the milestone 1.10.11 is enough and we'd cherry pick it.

Since you've got it opened I'll merge this though.

(We like cherry-picks to have the "(cherry picked from commit ...)" footer that -x adds, and our tooling to work out which commits are yet to be backported for a release relies upon the (#<PR>) on the end of the commit, so I have manually done both of these for this PR.)

@ashb ashb merged commit 5b48a53 into apache:v1-10-stable Jun 9, 2020
@eeshugerman
Copy link
Author

👍 I see, thanks, I was wondering how that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants