[AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

[houqp]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-XXX
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
  • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

• Here are some details about my PR, including screenshots of any UI changes:

After a heartbeat, time since last hearbeat will always be lower than heart rate, so the subsequent sleep is unnecessary. It also spams the task log with lots of info messages.

Sleep to maintain heart rate is already done by the heartbeat() call.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

[codecov-io]

Codecov Report

Merging #6553 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #6553     +/-   ##
=========================================
- Coverage   83.83%   83.53%   -0.3%     
=========================================
  Files         668      668             
  Lines       37569    37562      -7     
=========================================
- Hits        31497    31379    -118     
- Misses       6072     6183    +111

Impacted Files	Coverage Δ
airflow/jobs/local_task_job.py	89.33% <ø> (-0.67%)	⬇️
airflow/jobs/base_job.py	92.14% <100%> (+3.41%)	⬆️
airflow/kubernetes/volume_mount.py	44.44% <0%> (-55.56%)	⬇️
airflow/kubernetes/volume.py	52.94% <0%> (-47.06%)	⬇️
airflow/kubernetes/pod_launcher.py	45.25% <0%> (-46.72%)	⬇️
airflow/kubernetes/refresh_config.py	50.98% <0%> (-23.53%)	⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py	78.2% <0%> (-20.52%)	⬇️
airflow/configuration.py	89.13% <0%> (-3.63%)	⬇️
airflow/jobs/backfill_job.py	91.13% <0%> (-0.31%)	⬇️
airflow/utils/dag_processing.py	58.48% <0%> (+0.49%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fed459...b70687a. Read the comment docs.

[jj-ookla]

If the unit test changes are not approved, I would really like to see the removal of heart beat logging make its way into the next release. This has considerably inflated our log files.

https://github.com/apache/airflow/blob/master/airflow/jobs/local_task_job.py#L118

[houqp]

@jj-ian this exactly how I came to this patch :) Feel free to apply this patch to your cluster, we have been running airflow with it in production for a week now.

[houqp]

@ashb type annotation additions are not moved to #6674.