Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6080] fix type error from new version of mypy #6674

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

houqp
Copy link
Member

@houqp houqp commented Nov 26, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR fixes all errors reported by new version of mypy and updates CI to run mypy 0.740.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@houqp houqp force-pushed the mypy branch 2 times, most recently from 080a010 to 4ca26f1 Compare November 27, 2019 03:28
@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #6674 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6674      +/-   ##
==========================================
- Coverage   83.82%   83.52%   -0.31%     
==========================================
  Files         668      668              
  Lines       37543    37543              
==========================================
- Hits        31472    31356     -116     
- Misses       6071     6187     +116
Impacted Files Coverage Δ
airflow/gcp/utils/field_validator.py 92.3% <ø> (ø) ⬆️
airflow/contrib/operators/file_to_wasb.py 100% <ø> (ø) ⬆️
airflow/jobs/backfill_job.py 91.43% <ø> (ø) ⬆️
airflow/operators/dagrun_operator.py 96% <100%> (ø) ⬆️
airflow/models/taskinstance.py 93.46% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82008d...d404c9a. Read the comment docs.

@mppetkov
Copy link
Contributor

Hello, are you sure that this PR is related to https://issues.apache.org/jira/browse/AIRFLOW-6062 ? The code changes seem to be different. Thanks!

@ashb ashb changed the title [AIRFLOW-6062] fix type error from new version of mypy [AIRFLOW-6080] fix type error from new version of mypy Nov 27, 2019
@ashb
Copy link
Member

ashb commented Nov 27, 2019

Yup, should have been AIRFLOW-6080. I have updated.

@houqp
Copy link
Member Author

houqp commented Nov 27, 2019

My bad, copy pasted the wrong id. Thanks @ashb for fixing it :)

@ashb ashb merged commit a867db7 into apache:master Nov 30, 2019
@houqp houqp deleted the mypy branch November 30, 2019 16:46
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants