Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6159] Change logging level of the heartbeat message to DEBUG #6716

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Dec 2, 2019

Make sure you have checked all steps below.

Jira

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@kaxil kaxil requested review from ashb, potiuk and mik-laj December 2, 2019 22:58
Copy link
Contributor

@madison-ookla madison-ookla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this has been a big issue for us. #6553 removes this block entirely which would be an alternative, but this will help for now until that gets merged.

@kaxil kaxil merged commit 9fed459 into apache:master Dec 3, 2019
@kaxil kaxil deleted the AIRFLOW-6159-change-logging-level branch December 3, 2019 02:12
potiuk pushed a commit that referenced this pull request Dec 10, 2019
kaxil added a commit that referenced this pull request Dec 12, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants