Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6950] Remove refresh_executor_config from ti.refresh_from_db #7577

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 28, 2020

#5926 added "refresh_executor_config" argument to "refresh_from_db" which is never used. So we should remove it

We always use the latest executor_config from the task


Issue link: AIRFLOW-6950

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from dimberman February 28, 2020 02:06
@kaxil
Copy link
Member Author

kaxil commented Feb 28, 2020

CI failure looks unrelated

@kaxil kaxil merged commit 6a9b951 into apache:master Feb 28, 2020
@kaxil kaxil deleted the remove-refresh_executor_config branch February 28, 2020 13:10
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants