Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7076] Add support for HashiCorp Vault as Secrets Backend #7741

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 16, 2020

Add support for HashiCorp Vault as Secret Backend


Issue link: AIRFLOW-7076

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from potiuk March 16, 2020 23:24
@kaxil
Copy link
Member Author

kaxil commented Mar 16, 2020

cc @dstandish

@kaxil kaxil changed the title [AIRFLOW-7076] Add support for HashiCorp Vault as Secret Backend [AIRFLOW-7076] Add support for HashiCorp Vault as Secrets Backend Mar 16, 2020
@kaxil kaxil requested a review from ashb March 16, 2020 23:28
@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #7741 into master will decrease coverage by 0.84%.
The diff coverage is 65.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7741      +/-   ##
==========================================
- Coverage   86.96%   86.11%   -0.85%     
==========================================
  Files         920      921       +1     
  Lines       44436    44468      +32     
==========================================
- Hits        38644    38295     -349     
- Misses       5792     6173     +381     
Impacted Files Coverage Δ
airflow/secrets/__init__.py 97.67% <ø> (ø)
airflow/providers/hashicorp/secrets/vault.py 65.43% <65.43%> (ø)
...flow/providers/apache/cassandra/hooks/cassandra.py 21.51% <0.00%> (-72.16%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/providers/postgres/operators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-45.08%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029c84e...e39f971. Read the comment docs.

airflow/providers/hashicorp/secrets/vault.py Outdated Show resolved Hide resolved
airflow/providers/hashicorp/secrets/vault.py Outdated Show resolved Hide resolved
airflow/secrets/__init__.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@kaxil kaxil force-pushed the hvac-integration branch 2 times, most recently from e5a18bf to 0a965d5 Compare March 17, 2020 11:49
@kaxil kaxil requested a review from ashb March 17, 2020 12:47
@dephusluke
Copy link

@kaxil you added airflow/providers/hashicorp/secrets/vault.py
say that in future there will be a HashicorpVaultHook. Where would that go?
https://issues.apache.org/jira/browse/AIRFLOW-3669

Maybe I'm getting this wrong but I thought the providers package is for hooks/operators/sensor ?

@kaxil
Copy link
Member Author

kaxil commented Mar 18, 2020

@kaxil you added airflow/providers/hashicorp/secrets/vault.py
say that in future there will be a HashicorpVaultHook. Where would that go?
https://issues.apache.org/jira/browse/AIRFLOW-3669

Maybe I'm getting this wrong but I thought the providers package is for hooks/operators/sensor ?

That would go under airflow/providers/hashicorp/operator/

providers packages are for everything related to that specific provider

@kaxil kaxil merged commit a44beaf into apache:master Mar 19, 2020
@kaxil kaxil deleted the hvac-integration branch March 19, 2020 22:32
kaxil added a commit that referenced this pull request Mar 22, 2020
kaxil added a commit that referenced this pull request Mar 30, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants