[AIRFLOW-5705] Make AwsSsmSecretsBackend consistent with VaultBackend #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:secrets
provider:amazon-aws
dstandish
requested changes
Mar 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #7753 +/- ##
==========================================
- Coverage 86.96% 86.11% -0.85%
==========================================
Files 920 921 +1
Lines 44436 44462 +26
==========================================
- Hits 38644 38290 -354
- Misses 5792 6172 +380
Continue to review full report at Codecov.
|
kaxil
force-pushed
the
AwsSsmSecretsBackend-consistent
branch
from
6da2cde
to
1d7fb99
Compare
kaxil
force-pushed
the
AwsSsmSecretsBackend-consistent
branch
from
1d7fb99
to
d4b310d
Compare
kaxil
changed the title
ashb
reviewed
Mar 19, 2020
ashb
reviewed
Mar 19, 2020
ashb
reviewed
Mar 19, 2020
kaxil
changed the title
kaxil
force-pushed
the
AwsSsmSecretsBackend-consistent
branch
from
9655c92
to
5ba9497
Compare
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 28, 2020
…apache#7753) cherry-picked from a360024 (cherry picked from commit 9ad38a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this PR consistent with #7741 to remove the redundant AIRFLOW_CONN from secret key
and add more tests
Issue link: AIRFLOW-5705
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.
cc @dstandish