Get Airflow Variables from Hashicorp Vault #7944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:docs
area:secrets
provider:amazon-aws
This was referenced Mar 28, 2020
kaxil
force-pushed
the
add-variables-vault
branch
from
6b0de5b
to
c89534d
Compare
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #7944 +/- ##
===========================================
- Coverage 86.36% 61.07% -25.29%
===========================================
Files 929 931 +2
Lines 45036 45172 +136
===========================================
- Hits 38895 27590 -11305
- Misses 6141 17582 +11441
Continue to review full report at Codecov.
|
Separated it to a different PR #7948 |
kaxil
force-pushed
the
add-variables-vault
branch
from
c89534d
to
16a6ec7
Compare
kaxil
changed the title
kaxil
force-pushed
the
add-variables-vault
branch
from
16a6ec7
to
f822c7b
Compare
kaxil
changed the title
kaxil
force-pushed
the
add-variables-vault
branch
from
f822c7b
to
277e7fc
Compare
potiuk
approved these changes
Mar 28, 2020
|
Ci failure is unrelated |
kaxil
added a commit
that referenced
this pull request
Mar 28, 2020
(cherry picked from commit c1c88ab)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
(cherry picked from commit c1c88ab)
kaxil
added a commit
that referenced
this pull request
Mar 30, 2020
(cherry picked from commit c1c88ab)
kaxil
added a commit
that referenced
this pull request
Apr 1, 2020
(cherry picked from commit c1c88ab)
jacobhjkim
reviewed
Jul 7, 2020
| :return: Variable Value | ||
| """ | ||
| response = self._get_secret(self.variables_path, key) | ||
| return response.get("value") if response else None |
There was a problem hiding this comment.
@kaxil Why get response.get("value") instead of response[key]?
Specifically, why
variables
|- foo
| |- value = some_value
└ bar
└ value = another_value
Not
variables
|- foo = some_value
└ bar = another_value
This makes the structure simple.
There was a problem hiding this comment.
Hi @jacobhjkim it was mainly because we wanted to store each Variable as a separate secret (to have proper access control / avoid limits on a secret) and the fact that we use KV store, so we needed a key
There was a problem hiding this comment.
I see, thanks for the answer 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7948
Get Airflow Variables from Hashicorp Vault
Please only check the last commit
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.