Make BaseSecretsBackend.build_path generic #7948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the arguments required for it are `connections_prefix` and `conn_id` . Changing this to `path_prefix` and `secret_id` allows using that method for retrieving variables too
boring-cyborg
bot
added
area:secrets
provider:amazon-aws
This was referenced Mar 28, 2020
potiuk
approved these changes
Mar 28, 2020
5 tasks
mik-laj
reviewed
Mar 28, 2020
| @@ -150,7 +150,7 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]: | |||
| :param conn_id: connection id | |||
| :type conn_id: str | |||
| """ | |||
| secret_path = self.build_path(connections_prefix=self.connections_path, conn_id=conn_id) | |||
| secret_path = self.build_path(self.connections_path, conn_id) | |||
There was a problem hiding this comment.
Suggested change
| secret_path = self.build_path(self.connections_path, conn_id) | |
| secret_path = "/".join([self.connections_path, conn_id]) |
Do we need this method at all? This can be expressed with one line of code and will be more generic.
There was a problem hiding this comment.
It is a separate method for SecretsBackend Meta class so that each Backend can implement it as they all have a separate and all have a prefix and a path.
kaxil
added a commit
that referenced
this pull request
Mar 28, 2020
Currently the arguments required for it are `connections_prefix` and `conn_id` . Changing this to `path_prefix` and `secret_id` allows using that method for retrieving variables too (cherry picked from commit eb4af4f)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
Currently the arguments required for it are `connections_prefix` and `conn_id` . Changing this to `path_prefix` and `secret_id` allows using that method for retrieving variables too (cherry picked from commit eb4af4f)
kaxil
added a commit
that referenced
this pull request
Mar 30, 2020
Currently the arguments required for it are `connections_prefix` and `conn_id` . Changing this to `path_prefix` and `secret_id` allows using that method for retrieving variables too (cherry picked from commit eb4af4f)
kaxil
added a commit
that referenced
this pull request
Apr 1, 2020
Currently the arguments required for it are `connections_prefix` and `conn_id` . Changing this to `path_prefix` and `secret_id` allows using that method for retrieving variables too (cherry picked from commit eb4af4f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the arguments required for it are
connections_prefixandconn_id. Changing this topath_prefixandsecret_idallows using that method for retrieving variables tooIssue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.