-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist start/end date and duration for DummyOperator Task Instance #8663
Persist start/end date and duration for DummyOperator Task Instance #8663
Conversation
3d70468
to
fdc7694
Compare
Otherwise the behavior in UI is incorrect Addressing issue apache#8662
fdc7694
to
4a550ae
Compare
Sounds like there's also a bug in the UI code - I would have expected it to show nothing rather than current time |
Hi @ashb , IMO as a user it's good to know when this DummyOperator task is processed by the scheduler, so showing the start/end time for DummyOperator tasks in UI is useful |
Oh yes absolutely. I just meant cos of the bug with the missing fields I would have expected the UI to show nothing. |
Ha, get what you mean. That's exactly the behaviour in the non-RBAC UI. |
@ashb you are right that the UI JS code is handling this correctly,
ti.start_date and ti.end_date are always available. While they are none, it falls back to "default" value which is current time.
However I assume this is no longer an issue/bug if this PR is merged? |
Probably worth another pr to fix that. (This was a bug I introduced in my UI tz work - |
…pache#8663) Otherwise the behaviour in UI is incorrect Addressing issue apache#8662 (cherry picked from commit d92e848)
This PR is to address issue #8662
Currently, task instances of
DummyOperators
are always marked asSUCCESS
then immediately being skipped. Other entries likestart_date
,end_date
, andduration
are not marked for it in the database (intask_instance
table in DB,start_date
,end_date
, andduration
are allNULL
forDummyOperator
tasks).One of the issues resulted from this is that when we hover over task instances of
DummyOperator
in RBAC UI, the started and ended times are always showing the CURRENT time, instead of the the actual task started and ended time (like other operators/sensors).For details, please refer to #8662
Make sure to mark the boxes below before creating PR: [x]