Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fix: ensure "started"/"ended" in TI tooltips are not shown if the job not started yet #8667

Merged
merged 1 commit into from
May 2, 2020

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented May 1, 2020

This is to fix the UI bug identified in another PR #8663 (comment)

This must be applied together with #8663, otherwise the tooltip for DummyOperators will be shown incorrectly.

After fix:

Screenshot 2020-05-01 at 3 15 09 PM


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@XD-DENG XD-DENG added this to the Airflow 1.10.11 milestone May 1, 2020
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label May 1, 2020
@XD-DENG XD-DENG requested a review from ashb May 1, 2020 13:19
@XD-DENG
Copy link
Member Author

XD-DENG commented May 1, 2020

Hi @ashb , please have a look.

This is a simple fix by re-ordering a few lines, and it seems to me the result after the fix is consistent with your original intention in your JS code.

@XD-DENG
Copy link
Member Author

XD-DENG commented May 1, 2020

Will merge after #8663 is merged, due to the dependency mentioned in the description above.

@XD-DENG XD-DENG merged commit 0954140 into apache:master May 2, 2020
@XD-DENG XD-DENG deleted the bugfix/ui_datetime_fix branch May 2, 2020 19:13
kaxil pushed a commit that referenced this pull request Jun 28, 2020
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@kaxil kaxil added the type:improvement Changelog: Improvements label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants