Fix Spark Conn Add/Edit Pages #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XD-DENG
changed the title
zhongjiajie
reviewed
May 3, 2020
@zhongjiajie two changes are both small so appended the 2nd change here. But I don't mind splitting them into two. |
XD-DENG
force-pushed
the
fix/spark-connection
branch
from
03a2e50
to
79912b9
Compare
XD-DENG
changed the title
|
Hi @zhongjiajie , I have split the PR into two. The change to order connection types alphabetically is in PR #8692 The PR description, title, etc, of this PR are updated as well. Let me know if everything looks good to you? |
zhongjiajie
approved these changes
May 3, 2020
kaxil
pushed a commit
that referenced
this pull request
Jun 22, 2020
connection add/edit UI pages were not working correctly for Spark connections.
The root-cause is that "spark" is not listed in models.Connection._types.
So when www/forms.py tries to produce the UI,
"spark" is not available and it always tried to "fall back" to the option list
whose first entry is "Docker"
In addition, we should hide irrelevant entries for
spark connections ("schema", "login", and "password")
(cherry picked from commit 0b598a2)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
connection add/edit UI pages were not working correctly for Spark connections.
The root-cause is that "spark" is not listed in models.Connection._types.
So when www/forms.py tries to produce the UI,
"spark" is not available and it always tried to "fall back" to the option list
whose first entry is "Docker"
In addition, we should hide irrelevant entries for
spark connections ("schema", "login", and "password")
(cherry picked from commit 0b598a2)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
connection add/edit UI pages were not working correctly for Spark connections.
The root-cause is that "spark" is not listed in models.Connection._types.
So when www/forms.py tries to produce the UI,
"spark" is not available and it always tried to "fall back" to the option list
whose first entry is "Docker"
In addition, we should hide irrelevant entries for
spark connections ("schema", "login", and "password")
(cherry picked from commit 0b598a2)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
connection add/edit UI pages were not working correctly for Spark connections.
The root-cause is that "spark" is not listed in models.Connection._types.
So when www/forms.py tries to produce the UI,
"spark" is not available and it always tried to "fall back" to the option list
whose first entry is "Docker"
In addition, we should hide irrelevant entries for
spark connections ("schema", "login", and "password")
(cherry picked from commit 0b598a2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterand1.10.10, connection add/edit UI pages are not working correctly for Spark connections.Current Connection Adding for Spark ('Spark' in not available):
Current Connection Editing for Spark:
You can easily reproduce this by trying to edit default connection
spark_default.Root-cause
The root-cause is that "spark" is not listed in
models.Connection._types. So whenwww/forms.pytries to produce the UI, "spark" is not available and it always tried to "fall back" to the option list whose first entry is "Docker" (this is why we see "Docker Registry" when we edit "spark_default").In addition, we should hide irrelevant entries for spark connections ("schema", "login", and "password")
After Fix - Add Spark Connection
After Fix - Edit Spark Connection
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.