Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort connection type list in add/edit page alphabetically #8692

Merged
merged 1 commit into from
May 3, 2020

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented May 3, 2020

Currently the connection type list in the UI is sorted in the order of original Connection._types, which may be a bit inconvenient for users.

It would be better if it can be sorted alphabetically.

Pre-fix

80909345-d0877280-8d27-11ea-8f5d-2ebfa6dbb1c9

After Fix

80909357-ded58e80-8d27-11ea-91f5-b9e82ac682fd


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Currently the connection type list in the UI is sorted in the order of original `Connection._types`,
which may be a bit inconvenient for users.

It would be better if it can be sorted alphabetically.
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label May 3, 2020
@XD-DENG XD-DENG requested review from ashb, kaxil and zhongjiajie May 3, 2020 17:02
@XD-DENG XD-DENG mentioned this pull request May 3, 2020
6 tasks
@XD-DENG XD-DENG added this to the Airflow 1.10.11 milestone May 3, 2020
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for Github Action

@XD-DENG XD-DENG merged commit ffbbbfc into apache:master May 3, 2020
@XD-DENG
Copy link
Member Author

XD-DENG commented May 3, 2020

Thanks @zhongjiajie and @mik-laj

@XD-DENG XD-DENG deleted the sort-connections-alphabetically branch May 3, 2020 18:19
kaxil pushed a commit that referenced this pull request Aug 17, 2020
Currently the connection type list in the UI is sorted in the original order of
`Connection._types`, which may be a bit inconvenient for users.

It would be better if it can be sorted alphabetically.

(cherry picked from commit ffbbbfc)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Currently the connection type list in the UI is sorted in the original order of
`Connection._types`, which may be a bit inconvenient for users.

It would be better if it can be sorted alphabetically.

(cherry picked from commit ffbbbfc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants