Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendored nvd3 and slugify libraries #9136

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Remove vendored nvd3 and slugify libraries #9136

merged 1 commit into from
Jun 4, 2020

Conversation

ashb
Copy link
Member

@ashb ashb commented Jun 4, 2020 •
edited
Loading

We pulled in them because slugify used to default to the GPL'd
unidecode module, but since Slugify 3.0 it has used text-unidecode
by first (and only installs the GPL library by an optional extra, not by
default) so we can now use it.

This lets us upgreade text-unidecode from 1.2 to the latest 1.3, which
is the version one of dbt's dependencies needs.

Depends on #9137.

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ashb ashb mentioned this pull request Jun 4, 2020
Merged
6 tasks
@ashb ashb marked this pull request as draft June 4, 2020 12:41
@kaxil
Copy link
Member

kaxil commented Jun 4, 2020

Just for reference: un33k/python-slugify@f98b091#diff-04c6e90faac2675aa89e2176d2eec7d8

@ashb ashb marked this pull request as ready for review June 4, 2020 13:16
@ashb
Remove vendored nvd3 and slugify libraries
c8bfe89 
We pulled in them because slugify _used_ to default to the GPL'd
`unidecode` module, but since Slugify 3.0[1] it has used text-unidecode
by first (and only installs the GPL library by an optional extra, not by
default) so we can now use it.

This lets us upgreade text-unidecode from 1.2 to the latest 1.3, which
is the version one of dbt's dependencies needs.

[1]: https://github.com/un33k/python-slugify/blob/4.0.0/CHANGELOG.md#300
@ashb ashb merged commit 2580b04 into apache:master Jun 4, 2020
@ashb ashb deleted the remove-vendored-libs branch June 4, 2020 14:45
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 9, 2020
potiuk pushed a commit that referenced this pull request Jun 9, 2020
@ashb @potiuk
Remove vendored nvd3 and slugify libraries (#9136)
f16cae3 
We pulled in them because slugify _used_ to default to the GPL'd
`unidecode` module, but since Slugify 3.0[1] it has used text-unidecode
by first (and only installs the GPL library by an optional extra, not by
default) so we can now use it.

This lets us upgreade text-unidecode from 1.2 to the latest 1.3, which
is the version one of dbt's dependencies needs.

[1]: https://github.com/un33k/python-slugify/blob/4.0.0/CHANGELOG.md#300

(cherry picked from commit 2580b04)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@ashb @potiuk
Remove vendored nvd3 and slugify libraries (#9136)
5bffaf7 
We pulled in them because slugify _used_ to default to the GPL'd
`unidecode` module, but since Slugify 3.0[1] it has used text-unidecode
by first (and only installs the GPL library by an optional extra, not by
default) so we can now use it.

This lets us upgreade text-unidecode from 1.2 to the latest 1.3, which
is the version one of dbt's dependencies needs.

[1]: https://github.com/un33k/python-slugify/blob/4.0.0/CHANGELOG.md#300

(cherry picked from commit 2580b04)
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@ashb @kaxil
Remove vendored nvd3 and slugify libraries (#9136)
d55de34 
We pulled in them because slugify _used_ to default to the GPL'd
`unidecode` module, but since Slugify 3.0[1] it has used text-unidecode
by first (and only installs the GPL library by an optional extra, not by
default) so we can now use it.

This lets us upgreade text-unidecode from 1.2 to the latest 1.3, which
is the version one of dbt's dependencies needs.

[1]: https://github.com/un33k/python-slugify/blob/4.0.0/CHANGELOG.md#300

(cherry picked from commit 2580b04)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@ashb
Remove vendored nvd3 and slugify libraries (apache#9136)
985a7b4 
We pulled in them because slugify _used_ to default to the GPL'd
`unidecode` module, but since Slugify 3.0[1] it has used text-unidecode
by first (and only installs the GPL library by an optional extra, not by
default) so we can now use it.

This lets us upgreade text-unidecode from 1.2 to the latest 1.3, which
is the version one of dbt's dependencies needs.

[1]: https://github.com/un33k/python-slugify/blob/4.0.0/CHANGELOG.md#300

(cherry picked from commit 2580b04)
kaxil added a commit to astronomer/airflow that referenced this pull request May 14, 2021
@kaxil
Remove unused licenses: python-nvd3 & python-slugify
a03f5ee 
This was added when we vendorized nvd3 and slugify: apache@e36bdef

but we forgot to remove it in apache#9136
@kaxil kaxil mentioned this pull request May 14, 2021
Merged
kaxil added a commit that referenced this pull request May 14, 2021
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
8ecc835 
This was added when we vendorized nvd3 and slugify: e36bdef

but we forgot to remove it in #9136
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
2965328 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
94e1249 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 27, 2021
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
bbc02c4 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 10, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
a5862dd 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
848cd5f 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
3b95faa 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
4a38625 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
4d3ce4d 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
338360e 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
0fa9a0d 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
9267a4c 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
a701e2c 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 13, 2024
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
15e899e 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2024
@kaxil
Remove unused licenses: python-nvd3 & python-slugify (#15860)
71f1cfb 
This was added when we vendorized nvd3 and slugify: apache/airflow@e36bdef

but we forgot to remove it in apache/airflow#9136

GitOrigin-RevId: 8ecc8355c15e48e283a27392c2ed851b9bce7b8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
area:dev-tools
Projects
None yet
Milestone
Airflow 1.10.11
Development

Successfully merging this pull request may close these issues.
3 participants
@ashb @kaxil @potiuk