Restrict google-cloud-texttospeach to <v2 #9137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
commented
Jun 4, 2020
Version 2 of this library causes the following pylint errors: > airflow/providers/google/cloud/hooks/text_to_speech.py:59:27: E1123: Unexpected keyword argument 'client_info' in constructor call (unexpected-keyword-arg) > airflow/providers/google/cloud/hooks/text_to_speech.py:99:15: E1123: Unexpected keyword argument 'input_' in method call (unexpected-keyword-arg)
ashb
force-pushed
the
gcp-texttospeach-ver-limit
branch
from
8e6e4f2
to
3606ba4
Compare
mik-laj
approved these changes
Jun 4, 2020
6 tasks
kaxil
approved these changes
Jun 4, 2020
|
Looks like there might be a single slow/wedged test. 38m and counting :( |
|
Though it's passed in #9136 which includes the exact same commit. I'm going to merge anyway |
|
I've set this for 1.10.11 -- I'm not sure if we have this dep in 1.10.x or not, but we need to update that version even with backporting providers.. |
6 tasks
potiuk
pushed a commit
that referenced
this pull request
Jun 9, 2020
Version 2 of this library causes the following pylint errors: > airflow/providers/google/cloud/hooks/text_to_speech.py:59:27: E1123: Unexpected keyword argument 'client_info' in constructor call (unexpected-keyword-arg) > airflow/providers/google/cloud/hooks/text_to_speech.py:99:15: E1123: Unexpected keyword argument 'input_' in method call (unexpected-keyword-arg) (cherry picked from commit aa89900)
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
Version 2 of this library causes the following pylint errors: > airflow/providers/google/cloud/hooks/text_to_speech.py:59:27: E1123: Unexpected keyword argument 'client_info' in constructor call (unexpected-keyword-arg) > airflow/providers/google/cloud/hooks/text_to_speech.py:99:15: E1123: Unexpected keyword argument 'input_' in method call (unexpected-keyword-arg) (cherry picked from commit aa89900)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
Version 2 of this library causes the following pylint errors: > airflow/providers/google/cloud/hooks/text_to_speech.py:59:27: E1123: Unexpected keyword argument 'client_info' in constructor call (unexpected-keyword-arg) > airflow/providers/google/cloud/hooks/text_to_speech.py:99:15: E1123: Unexpected keyword argument 'input_' in method call (unexpected-keyword-arg) (cherry picked from commit aa89900)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Version 2 of this library causes the following pylint errors: > airflow/providers/google/cloud/hooks/text_to_speech.py:59:27: E1123: Unexpected keyword argument 'client_info' in constructor call (unexpected-keyword-arg) > airflow/providers/google/cloud/hooks/text_to_speech.py:99:15: E1123: Unexpected keyword argument 'input_' in method call (unexpected-keyword-arg) (cherry picked from commit aa89900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2 of this library causes the following pylint errors:
This was noticed when I tried to update requirements in #9136 (now rebased to be on top of this PR)
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.