Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement new_null_array for view types #5894

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

XiangpengHao
Copy link
Contributor

Which issue does this PR close?

Closes #5893 .

Rationale for this change

Very simple fix + very simple tests

As I start integrating view types in DataFusion, I expect more such unhandled cases to surface. Let me know if we want to do fine-grained case-by-case fix (like the current pr), or try to batch multiple fixes (so they won't flood people's notifications)...

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XiangpengHao

As I start integrating view types in DataFusion, I expect more such unhandled cases to surface. Let me know if we want to do fine-grained case-by-case fix (like the current pr), or try to batch multiple fixes (so they won't flood people's notifications)...

I personally prefer multiple small PRs

BTW we should probably figure out how you will get these fixes into DataFusion as there won't be an arrow-rs release for a few weeks

Maybe it is time to create a datafusion "string-view-feature-branch" or something and pin to the head of arrow-rs 🤔

@alamb alamb changed the title implement new null for view types implement new_null_array for view types Jun 15, 2024
@alamb
Copy link
Contributor

alamb commented Jun 15, 2024

I also double checked that this function is what is used by new_null_array: https://docs.rs/arrow-array/52.0.0/src/arrow_array/array/mod.rs.html#668

@alamb alamb merged commit c7513bd into apache:master Jun 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New null with view types are not supported
2 participants