Skip to content

Commit

Permalink
GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Doc…
Browse files Browse the repository at this point in the history
…ker on Windows on archery (#41120)

### Rationale for this change

Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows.

### What changes are included in this PR?

Do not use `--progress` on the Windows builds.

### Are these changes tested?

Yes on CI via archery.

### Are there any user-facing changes?
No
* GitHub Issue: #41119

Lead-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
raulcd and kou committed Apr 11, 2024
1 parent 4d3d4ac commit b18b1f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dev/archery/archery/docker/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def _build(service, use_cache):
self._execute_docker("buildx", "build", *args)
elif self.config.using_docker:
# better for caching
if self.config.debug:
if self.config.debug and os.name != "nt":
args.append("--progress=plain")
for k, v in service['build'].get('args', {}).items():
args.extend(['--build-arg', '{}={}'.format(k, v)])
Expand All @@ -324,7 +324,7 @@ def _build(service, use_cache):
])
self._execute_docker("build", *args)
else:
if self.config.debug:
if self.config.debug and os.name != "nt":
args.append("--progress=plain")
self._execute_compose("build", *args, service['name'])

Expand Down

0 comments on commit b18b1f4

Please sign in to comment.