GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery #41120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit wheel-windows-* |
|
Revision: 82d4ade Submitted crossbow builds: ursacomputing/crossbow @ actions-d7303f0760
|
|
@kou are you ok with this? This is needed for 16.0.0 |
github-actions
bot
added
awaiting merge
|
Or can we remove --progress on Windows? |
…on Windows wheels as --progress flag is not supported on Docker on Windows
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit wheel-windows-* |
github-actions
bot
added
awaiting change review
|
Revision: af01e7b Submitted crossbow builds: ursacomputing/crossbow @ actions-28a241eefe
|
@kou I've updated the PR to do that. |
raulcd
changed the title
|
@github-actions crossbow submit wheel-windows-* |
This reverts commit f6580cd.
|
Revision: f6580cd Submitted crossbow builds: ursacomputing/crossbow @ actions-17855e7166
|
kou
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
+1
No --progress=plain:
https://github.com/ursacomputing/crossbow/actions/runs/8637649581/job/23680319104#step:7:72
DEBUG:archery:Executing `['docker', 'build', '--build-arg', 'BUILDKIT_INLINE_CACHE=1', '--build-arg', 'python=3.11', '--build-arg', 'vcpkg=a42af01b72c28a8e1d7b48107b33e4f286a55ef6', '-f', 'D:\\a\\crossbow\\crossbow\\arrow\\ci/docker/python-wheel-windows-vs2019.dockerfile', '-t', 'ghcr.io/ursacomputing/arrow:python-3.11-wheel-windows-vs2019-vcpkg-a42af01b72c28a8e1d7b48107b33e4f286a55ef6-2024-04-11', 'D:\\a\\crossbow\\crossbow\\arrow']`
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 06f0e0c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
raulcd
added a commit
that referenced
this pull request
Apr 11, 2024
…ker on Windows on archery (#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: #41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
Apr 15, 2024
…on Docker on Windows on archery (apache#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
…on Docker on Windows on archery (apache#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 4, 2024
…on Docker on Windows on archery (apache#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
…on Docker on Windows on archery (apache#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
…on Docker on Windows on archery (apache#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…on Docker on Windows on archery (apache#41120) ### Rationale for this change Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default. This uses `--progress` on `docker build` which is not supported on Windows. ### What changes are included in this PR? Do not use `--progress` on the Windows builds. ### Are these changes tested? Yes on CI via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#41119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Windows wheels are currently failing due to the change on
ARCHERY_DEBUG=1by default. This uses--progressondocker buildwhich is not supported on Windows.What changes are included in this PR?
Do not use
--progresson the Windows builds.Are these changes tested?
Yes on CI via archery.
Are there any user-facing changes?
No
unknown flag: --progresson docker build #41119