GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

Tom-Newton · 2024-02-18T17:04:36Z

Rationale for this change

Prevent confusion if a user attempts to read or write a directory.

What changes are included in this PR?

Make ObjectAppendStream::Flush a noop if ObjectAppendStream::Init has not run successfully. This avoids an unhandled error when the destructor calls flush.
Check blob properties for directory marker metadata when initialising ObjectInputFile or ObjectAppendStream.
When initialising ObjectAppendStream call GetFileInfo if it is a flat namespace account.

Are these changes tested?

Add new tests DisallowReadingOrWritingDirectoryMarkers and DisallowCreatingFileAndDirectoryWithTheSameName to cover the new fail fast behaviour.
Also updated WriteMetadata to ensure that my changes to Flush didn't break setting metadata without calling Write on the stream.

Are there any user-facing changes?

Yes. Invalid read and write operations will now fail fast and gracefully. Previously could get into a confusing state where there were files and directories at the same path and there were some un-graceful failures.

Closes: [C++][FS][Azure] Prevent reading or writing directory marker blobs #40037

…ling slash

Tom-Newton · 2024-02-18T17:05:21Z

@felipecrv I expect you will be interested in reviewing this.

cpp/src/arrow/filesystem/azurefs.cc

felipecrv · 2024-02-20T15:00:53Z

cpp/src/arrow/filesystem/azurefs.cc

-      DCHECK_GE(content_length_, 0);
-      pos_ = content_length_;
+  Status Init(const bool truncate,
+              std::function<Status()> ensure_not_flat_namespace_directory) {


You can inject AzureFileSystem *azure_file_system here and not have to allocate a closure for this. You would call AzureFileSystem::Impl::EnsureNotFlatNamespaceDirectory(location) via azure_file_system->impl_ (accessible because the handles produced by the azure file system can be friends with the filesystem class).

Thanks for the extra info. I was planning to do this but I was struggling with the friends thing.

The trick is to forward-declare the class as well.

diff --git a/cpp/src/arrow/filesystem/azurefs.h b/cpp/src/arrow/filesystem/azurefs.h index 2a131e40c..d48ef9dd7 100644 --- a/cpp/src/arrow/filesystem/azurefs.h +++ b/cpp/src/arrow/filesystem/azurefs.h @@ -44,6 +44,7 @@ class DataLakeServiceClient; namespace arrow::fs { +class ObjectAppendStream; class TestAzureFileSystem; /// Options for the AzureFileSystem implementation. @@ -180,6 +181,7 @@ class ARROW_EXPORT AzureFileSystem : public FileSystem { explicit AzureFileSystem(std::unique_ptr<Impl>&& impl); + friend class ObjectAppendStream; friend class TestAzureFileSystem; void ForceCachedHierarchicalNamespaceSupport(int hns_support);

I think my main problem was that ObjectAppendStream is defined inside an anonymous namespace but I still haven't got it working as you describe.

Are you suggesting to use AzureFileSystem *azure_file_system or AzureFileSystem:Impl *azure_file_system as the argument to ObjectAppendStream::Impl. I don't know how I can get a AzureFileSystem pointer from inside AzureFileSystem::Impl and using AzureFileSystem::Impl as the argument leads to incomplete type errors which I don't think I can avoid.

Also if you wouldn't mind I would be interested to know what the disadvantage of a lambda function is compared to what you proposed.

Sorry about my lacking C++ knowledge here.

Also if you wouldn't mind I would be interested to know what the disadvantage of a lambda function is compared to what you proposed.

To create the std::function, you heap allocate an object with copies of the values in the capture list and generate a lot more extra code in the binary:

class function { T valuesfromthecpapturelist; RetType operator()(ArgsType ...) {...}; }

When you think about an std::function this way (a pair of context data and a function), you realize the class you already serves that purpose.

But hey, this is becoming challenging, so I won't hold the PR anymore because of this. Moving to Init() was a big step in the right direction.

Thanks for explaining

cpp/src/arrow/filesystem/azurefs.cc

felipecrv · 2024-02-21T01:24:35Z

cpp/src/arrow/filesystem/azurefs.cc

-      DCHECK_GE(content_length_, 0);
-      pos_ = content_length_;
+  Status Init(const bool truncate,
+              std::function<Status()> ensure_not_flat_namespace_directory) {


Also if you wouldn't mind I would be interested to know what the disadvantage of a lambda function is compared to what you proposed.

To create the std::function, you heap allocate an object with copies of the values in the capture list and generate a lot more extra code in the binary:

class function { T valuesfromthecpapturelist; RetType operator()(ArgsType ...) {...}; }

When you think about an std::function this way (a pair of context data and a function), you realize the class you already serves that purpose.

But hey, this is becoming challenging, so I won't hold the PR anymore because of this. Moving to Init() was a big step in the right direction.

felipecrv · 2024-02-21T01:59:35Z

cpp/src/arrow/filesystem/azurefs_test.cc

+TYPED_TEST(TestAzureFileSystemOnAllScenarios,
+           OpenOutputStreamWithMissingContainer) {


This is causing the linter to fail @Tom-Newton. Please fix and I will merge.

conbench-apache-arrow · 2024-02-22T10:55:25Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T11:17:41Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T11:27:53Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T11:35:50Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T11:44:59Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T12:06:05Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T12:35:47Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T12:48:46Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T12:55:28Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T13:00:24Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T13:15:06Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T13:45:52Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T13:50:37Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T13:55:13Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T14:06:12Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T14:25:11Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T14:35:01Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

conbench-apache-arrow · 2024-02-22T14:53:47Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

austin3dickey · 2024-02-22T15:09:09Z

My apologies for the noise. Looking into this now.

conbench-apache-arrow · 2024-02-22T15:53:15Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8a62f30.

There was 1 benchmark result with an error:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-21, scale_factor=10

There were 2 benchmark results indicating a performance regression:

Commit Run on ursa-i9-9960x at 2024-02-21 17:26:57Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-04, scale_factor=1
- dataframe-to-table (R) with dataset=type_integers, language=R

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

austin3dickey · 2024-02-22T15:53:46Z

That should be the last one. Sorry again about the noise!

felipecrv · 2024-02-22T19:14:34Z

@austin3dickey no worries :)

…nst directories fail fast (apache#40119) ### Rationale for this change Prevent confusion if a user attempts to read or write a directory. ### What changes are included in this PR? - Make `ObjectAppendStream::Flush` a noop if `ObjectAppendStream::Init` has not run successfully. This avoids an unhandled error when the destructor calls flush. - Check blob properties for directory marker metadata when initialising `ObjectInputFile` or `ObjectAppendStream`. - When initialising `ObjectAppendStream` call `GetFileInfo` if it is a flat namespace account. ### Are these changes tested? Add new tests `DisallowReadingOrWritingDirectoryMarkers` and `DisallowCreatingFileAndDirectoryWithTheSameName` to cover the new fail fast behaviour. Also updated `WriteMetadata` to ensure that my changes to Flush didn't break setting metadata without calling `Write` on the stream. ### Are there any user-facing changes? Yes. Invalid read and write operations will now fail fast and gracefully. Previously could get into a confusing state where there were files and directories at the same path and there were some un-graceful failures. * Closes: apache#40037 Authored-by: Thomas Newton <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>

Tom-Newton added 13 commits February 18, 2024 12:21

Add MetadataIndicatesIsDirectory function

b305c14

Return not a file if trying to read or write a directory

af47546

Add tests

e0d5d2b

Avoid some unhandled exceptions in destructor

67a5e20

Add test DisallowCreatingFileAndDirectoryWithTheSameName

5388f67

Add test cases for DisallowReadingOrWritingDirectoryMarkers with trai…

25dff2f

…ling slash

Add comments explaining the strategy with ObjectInputFile

bfdd719

Ensure not a directory on OpenOutputStream and OpenAppendStream

ff72cdf

More complete tests

8f573cb

Tidy

f71cc50

Add an assertion that metadata can be written without modifying the file

37862c2

Avoid errors in destructor more neatly

28e9bdd

Small update to WriteMetadata test

26d6e96

github-actions bot added Component: C++ awaiting review Awaiting review labels Feb 18, 2024

Auto-format

ab02113

felipecrv requested changes Feb 19, 2024

View reviewed changes

cpp/src/arrow/filesystem/azurefs.cc Outdated Show resolved Hide resolved

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 19, 2024

Move arguments to ObjectAppendStream Init instead of constructor

b905f5d

felipecrv requested changes Feb 20, 2024

View reviewed changes

Tom-Newton added 2 commits February 21, 2024 00:23

Add a test case for outputstream when container does not exist

aec7b34

Avoid unnecessary API call if kContainerNotFound

be33953

felipecrv approved these changes Feb 21, 2024

View reviewed changes

felipecrv reviewed Feb 21, 2024

View reviewed changes

Tom-Newton added 3 commits February 21, 2024 08:42

Fix lint

5ddd70c

Tidy

8ac3c95

Lint again

111abbb

felipecrv approved these changes Feb 21, 2024

View reviewed changes

felipecrv merged commit 8a62f30 into apache:main Feb 21, 2024
34 of 35 checks passed

felipecrv removed the awaiting committer review Awaiting committer review label Feb 21, 2024

github-actions bot added the awaiting committer review Awaiting committer review label Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

Tom-Newton commented Feb 18, 2024 •

edited by github-actions bot

Loading

Tom-Newton commented Feb 18, 2024

felipecrv Feb 20, 2024

Tom-Newton Feb 20, 2024 •

edited

Loading

felipecrv Feb 20, 2024

Tom-Newton Feb 21, 2024 •

edited

Loading

felipecrv Feb 21, 2024

Tom-Newton Feb 21, 2024

felipecrv Feb 21, 2024

felipecrv Feb 21, 2024

Tom-Newton Feb 21, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

austin3dickey commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

austin3dickey commented Feb 22, 2024

felipecrv commented Feb 22, 2024

		TYPED_TEST(TestAzureFileSystemOnAllScenarios,
		OpenOutputStreamWithMissingContainer) {

GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

Conversation

Tom-Newton commented Feb 18, 2024 • edited by github-actions bot Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Tom-Newton commented Feb 18, 2024

felipecrv Feb 20, 2024

Choose a reason for hiding this comment

Tom-Newton Feb 20, 2024 • edited Loading

Choose a reason for hiding this comment

felipecrv Feb 20, 2024

Choose a reason for hiding this comment

Tom-Newton Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

felipecrv Feb 21, 2024

Choose a reason for hiding this comment

Tom-Newton Feb 21, 2024

Choose a reason for hiding this comment

felipecrv Feb 21, 2024

Choose a reason for hiding this comment

felipecrv Feb 21, 2024

Choose a reason for hiding this comment

Tom-Newton Feb 21, 2024

Choose a reason for hiding this comment

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

austin3dickey commented Feb 22, 2024

conbench-apache-arrow bot commented Feb 22, 2024

austin3dickey commented Feb 22, 2024

felipecrv commented Feb 22, 2024

Tom-Newton commented Feb 18, 2024 •

edited by github-actions bot

Loading

Tom-Newton Feb 20, 2024 •

edited

Loading

Tom-Newton Feb 21, 2024 •

edited

Loading