Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

Merged
merged 20 commits into from
Feb 21, 2024
Merged

GH-40037: [C++][FS][Azure] Make attempted reads and writes against directories fail fast #40119

merged 20 commits into from
Feb 21, 2024

Commits on Feb 18, 2024

  1. Add MetadataIndicatesIsDirectory function

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    b305c14 View commit details
    Browse the repository at this point in the history

  2. Return not a file if trying to read or write a directory

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    af47546 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    e0d5d2b View commit details
    Browse the repository at this point in the history

  4. Avoid some unhandled exceptions in destructor

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    67a5e20 View commit details
    Browse the repository at this point in the history

  5. Add test DisallowCreatingFileAndDirectoryWithTheSameName

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    5388f67 View commit details
    Browse the repository at this point in the history

  6. Add test cases for DisallowReadingOrWritingDirectoryMarkers with trai… 

    …ling slash
    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    25dff2f View commit details
    Browse the repository at this point in the history

  7. Add comments explaining the strategy with ObjectInputFile

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    bfdd719 View commit details
    Browse the repository at this point in the history

  8. Ensure not a directory on OpenOutputStream and OpenAppendStream

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    ff72cdf View commit details
    Browse the repository at this point in the history

  9. More complete tests

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    8f573cb View commit details
    Browse the repository at this point in the history

  10. Tidy

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    f71cc50 View commit details
    Browse the repository at this point in the history

  11. Add an assertion that metadata can be written without modifying the file

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    37862c2 View commit details
    Browse the repository at this point in the history

  12. Avoid errors in destructor more neatly

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    28e9bdd View commit details
    Browse the repository at this point in the history

  13. Small update to WriteMetadata test

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    26d6e96 View commit details
    Browse the repository at this point in the history

  14. Auto-format

    @Tom-Newton
    Tom-Newton committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    ab02113 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Move arguments to ObjectAppendStream Init instead of constructor

    @Tom-Newton
    Tom-Newton committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b905f5d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Add a test case for outputstream when container does not exist

    @Tom-Newton
    Tom-Newton committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    aec7b34 View commit details
    Browse the repository at this point in the history

  2. Avoid unnecessary API call if kContainerNotFound

    @Tom-Newton
    Tom-Newton committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    be33953 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @Tom-Newton
    Tom-Newton committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5ddd70c View commit details
    Browse the repository at this point in the history

  4. Tidy

    @Tom-Newton
    Tom-Newton committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8ac3c95 View commit details
    Browse the repository at this point in the history

  5. Lint again

    @Tom-Newton
    Tom-Newton committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    111abbb View commit details
    Browse the repository at this point in the history