Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: platform version logic #1206

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 1, 2021

Motivation, Context & Description

  • Get platform version from package.json
  • Remove old VERSION file which is not used as apart of the CLI workflow.

Testing

  • npm t
  • create project and tested with commands:
    • cordova info
    • cordova platform
    • cordova build

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 7.0.0 milestone Dec 1, 2021
@erisu erisu requested a review from raphinesse December 1, 2021 11:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #1206 (4be7435) into master (30954ae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files          15       15           
  Lines        1761     1761           
=======================================
  Hits         1383     1383           
  Misses        378      378           
Impacted Files Coverage Δ
lib/Api.js 71.76% <100.00%> (ø)
lib/create.js 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30954ae...4be7435. Read the comment docs.

@erisu erisu changed the title Refactor/get version from package refactor: version from package.json Dec 1, 2021
@erisu erisu changed the title refactor: version from package.json refactor: platform version logic Dec 1, 2021
@erisu erisu merged commit 8474a3c into apache:master Dec 2, 2021
@erisu erisu deleted the refactor/get-version-from-package branch December 2, 2021 01:31
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
* refactor: pull platform version from package.json
* chore: remove old VERSION file and logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants