refactor: platform version logic (apache#1206)

* refactor: pull platform version from package.json * chore: remove old VERSION file and logic
apicore-engineering · Aug 26, 2022 · e49a753 · e49a753
1 parent d9c3df5
commit e49a753
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 13 deletions.
diff --git a/Cordova.podspec b/Cordova.podspec
@@ -34,7 +34,6 @@ Pod::Spec.new do |s|
   s.platform            = :ios, "11.0"
   s.source              = relSource
   s.requires_arc        = true
-  s.preserve_paths      = 'CordovaLib/VERSION'
   s.frameworks          = 'Foundation'
   s.source_files        = 'CordovaLib/**/*.{h,m}'
   s.public_header_files = 'CordovaLib/include/**/*.h'

diff --git a/CordovaLib/VERSION b/CordovaLib/VERSION
diff --git a/Package.swift b/Package.swift
@@ -34,9 +34,9 @@ let package = Package(
         .target(
             name: "Cordova",
             path: "CordovaLib/",
-            exclude: ["VERSION", "cordova.js", "Cordova/Cordova.h", "Cordova/Info.plist"],
+            exclude: ["cordova.js", "Cordova/Cordova.h", "Cordova/Info.plist"],
             cSettings: [
-              .headerSearchPath("Classes/Private")
+                .headerSearchPath("Classes/Private")
             ]
         )
     ]

diff --git a/lib/Api.js b/lib/Api.js
@@ -19,14 +19,7 @@
 
 /* jslint node: true */
 
-/**
- * @todo update coho to update this line.
- * @todo use `package.json` instead but first
- *  figure out how this fit in with the platform-centered workflow structure.
- *  This workflow would not have the `package.json` file.
- */
-// Coho updates this line
-const VERSION = '7.0.0-dev';
+const VERSION = require('../package.json').version;
 
 const fs = require('fs-extra');
 const path = require('path');

diff --git a/lib/create.js b/lib/create.js
@@ -118,7 +118,7 @@ class ProjectCreator {
             // like it should).
             fs.symlinkSync(cordovaLibPathSrc, cordovaLibPathDest);
         } else {
-            for (const p of ['include', 'Classes', 'VERSION', 'CordovaLib.xcodeproj/project.pbxproj']) {
+            for (const p of ['include', 'Classes', 'CordovaLib.xcodeproj/project.pbxproj']) {
                 fs.copySync(path.join(cordovaLibPathSrc, p), path.join(cordovaLibPathDest, p));
             }
         }