fix(splashscreen): positioning after rotation #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1315 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 15 15
Lines 1780 1780
=======================================
Hits 1397 1397
Misses 383 383 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erisu
changed the title
|
@dpogue You created this PR, but I would indeed appreciate partial credit. Thanks for asking. |
Closes apache#1231. Co-Authored-By: Michael Goffioul <[email protected]>
3 tasks
3 tasks
breautek
added a commit
to totalpaveinc/cordova-ios
that referenced
this pull request
Apr 5, 2024
This reverts commit 1a5cd45.
jessyefuster
pushed a commit
to jessyefuster/cordova-ios
that referenced
this pull request
Apr 30, 2024
Revert "fix(splashscreen): positioning after rotation (apache#1315)" This reverts commit 1a5cd45.
5 tasks
jessyefuster
added a commit
to jessyefuster/cordova-ios
that referenced
this pull request
Apr 30, 2024
Revert "fix(splashscreen): positioning after rotation (apache#1315)" This reverts commit 1a5cd45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
ios
Motivation and Context
Closes #1231.
Description
Add constraints to the splashscreen view so that it keeps the aspect ratio and positioning when the device is rotated.
@goffioul This is mostly the code that you proposed, do you want to be credited on the commit for this?
Testing
Tested on an iOS Simulator.
Checklist