Task/prefer physical device if connected

[johanlantz]

If there is a physical android device connected, use it

Includes #24

[janpio]

If you hope for passing tests: #34 has to be merged and this branch then rebased onto master after that unfortunately ;)

[johanlantz]

Ok, all the changes are rather small but helped a lot with getting Android to work better.

It might be faster for you to just look at the last PR and if you like the accumulated changes, simply copy paste them?

[janpio]

Ah, now I see that these are staggered pull requests - each one adding another feature. I will edit your description to reflect that.

[janpio]

This PR is currently missing the implementation of Util.getAndroidPhysicalDevice.

[janpio]

Seems this is it: https://github.com/Alpha-health/cordova-paramedic/blob/c103ca74624dee69b145b59864bbc45dffe71e3d/lib/utils/utilities.js#L56-L72

[janpio]

Ah, was added in your fork in a later commit as well: koa-health@66b6b27#diff-c25f5436d57d8f3c5b863535e37855d4

Could you please cherry pick this commit and also the following one into this branch?

koa-health@9f0dafe#diff-c25f5436d57d8f3c5b863535e37855d4

That should make the file correct.

[janpio]

I think #46 is exactly what I asked for in my previous comment. So it probably makes sense to not merge this one, and just merge the other one. Correct?

[janpio]

util.getAndroidPhysicalDevice is missing here

#46 does have it (and more)

[johanlantz]

Sorry about the staggered PR's. I was not sure which was the best way to send the PR's so I just took the PR's I had and created new ones back from the fork. I understand this was not optimal but hopefully the last one that contains all changes is small enough to decide if you want to integrate the changes or not.

[janpio]

It is small enough, but I still want to merge the changes feature by feature.

But I can edit your PR branches, so I should be able to just "mangle" them until they fit our needs ;)

Thanks for opening the PRs, I will see when I can get through them all and let you know in each one what happens (or not).