Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes #46

Merged
merged 9 commits into from
Nov 24, 2018
Merged

Various changes #46

merged 9 commits into from
Nov 24, 2018

Conversation

johanlantz
Copy link
Contributor

@johanlantz johanlantz commented Oct 1, 2018 •
edited by janpio
Loading

Extra fix for real device detection on Android.

Includes #24, #25, #43, #44, #45

@janpio janpio mentioned this pull request Oct 2, 2018
Closed
@janpio janpio changed the base branch from master to johanlantz November 24, 2018 17:56
@janpio janpio changed the title Task/separate emulator if there is a real device Various changes Nov 24, 2018
@janpio janpio merged commit 04b6204 into apache:johanlantz Nov 24, 2018
@janpio
Copy link
Member

janpio commented Nov 24, 2018

I merged this PR into a new johanlantz branch here in the repo. This will it make easiest for me to separate the individual changes into individual PRs that I can merge, and the commits will still be attributed to you.

I closed all the other individual PRs.

@johanlantz
Copy link
Contributor Author

👍

@janpio
Copy link
Member

janpio commented Nov 24, 2018

Now at: #56 #57 #58 #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

Assignees
No one assigned
Labels
depends-on-other-PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanlantz @janpio