-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Box from Sort #12207
Remove Box from Sort #12207
Conversation
`expr::Sort` had `Box<Expr>` because Sort was also an expression (via `expr::Expr::Sort`). This has been removed, obsoleting need to use a `Box`.
9840b8f
to
03d6167
Compare
thanks again @crepererum for merging #12177 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, thank you @findepi .
thank you @crepererum @lewiszlw for your reviews! |
expr::Sort
hadBox<Expr>
because Sort was also an expression (viaexpr::Expr::Sort
). This has been removed, obsoleting need to use aBox
.Extracted from
and based on#12177 to reduce PR scope