-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable needless_pass_by_value clippy lint #12243
Draft
findepi
wants to merge
1
commit into
apache:main
Choose a base branch
from
findepi:findepi/needless_pass_by_value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
SQL Planner
logical-expr
Logical plan and expressions
physical-expr
Physical Expressions
optimizer
Optimizer rules
core
Core DataFusion crate
sqllogictest
SQL Logic Tests (.slt)
substrait
common
Related to common crate
execution
Related to the execution crate
proto
Related to proto crate
functions
labels
Aug 29, 2024
cc @crepererum |
findepi
force-pushed
the
findepi/needless_pass_by_value
branch
from
August 29, 2024 21:06
6528d96
to
731b64b
Compare
could you try to factor out the API changes into separate PRs? This would make the reviews and the changelog generation a bit easier. |
findepi
force-pushed
the
findepi/needless_pass_by_value
branch
from
August 30, 2024 11:37
731b64b
to
69bc660
Compare
This was referenced Aug 30, 2024
findepi
force-pushed
the
findepi/needless_pass_by_value
branch
from
August 30, 2024 13:03
69bc660
to
978f0b5
Compare
good call! extracted these for now |
findepi
force-pushed
the
findepi/needless_pass_by_value
branch
from
September 6, 2024 18:50
978f0b5
to
59d0bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common
Related to common crate
core
Core DataFusion crate
execution
Related to the execution crate
functions
logical-expr
Logical plan and expressions
optimizer
Optimizer rules
physical-expr
Physical Expressions
proto
Related to proto crate
sql
SQL Planner
sqllogictest
SQL Logic Tests (.slt)
substrait
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12197 (comment)