Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add registry metrics #2366

Merged
merged 2 commits into from
Jul 31, 2023
Merged

add registry metrics #2366

merged 2 commits into from
Jul 31, 2023

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Jul 28, 2023

dubbo_register_service_rt_milliseconds_avg
dubbo_register_service_rt_milliseconds_last
dubbo_register_service_rt_milliseconds_max
dubbo_register_service_rt_milliseconds_min
dubbo_register_service_rt_milliseconds_sum

dubbo_registry_directory_num_all
dubbo_registry_directory_num_disable_total
dubbo_registry_directory_num_to_reconnect_total
dubbo_registry_directory_num_valid_total

dubbo_registry_notify_num_last
dubbo_registry_notify_requests_total

dubbo_register_rt_milliseconds_max
dubbo_register_rt_milliseconds_avg
dubbo_register_rt_milliseconds_sum
dubbo_register_rt_milliseconds_min
dubbo_register_rt_milliseconds_last

dubbo_registry_register_requests_succeed_total
dubbo_registry_register_requests_total
dubbo_registry_register_requests_failed_total

dubbo_registry_register_service_total
dubbo_registry_register_service_succeed_total
dubbo_registry_register_service_failed_total
dubbo_registry_subscribe_num_failed_total
dubbo_registry_subscribe_num_succeed_total

dubbo_registry_subscribe_num_total
dubbo_registry_subscribe_service_num_total
dubbo_registry_subscribe_service_num_succeed_total
dubbo_registry_subscribe_service_num_failed_total

dubbo_notify_rt_milliseconds_avg
dubbo_notify_rt_milliseconds_last
dubbo_notify_rt_milliseconds_max
dubbo_notify_rt_milliseconds_min
dubbo_notify_rt_milliseconds_sum

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FinalT FinalT mentioned this pull request Jul 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2366 (8592e11) into feature-metrics (d0c3564) will decrease coverage by 0.04%.
The diff coverage is 43.75%.

❗ Current head 8592e11 differs from pull request most recent head 642e0e0. Consider uploading reports for the commit 642e0e0 to get more accurate results

@@                 Coverage Diff                 @@
##           feature-metrics    #2366      +/-   ##
===================================================
- Coverage            44.11%   44.07%   -0.04%     
===================================================
  Files                  304      304              
  Lines                18430    18446      +16     
===================================================
  Hits                  8130     8130              
- Misses                9445     9462      +17     
+ Partials               855      854       -1     
Files Changed Coverage Δ
registry/base_registry.go 1.39% <0.00%> (-0.02%) ⬇️
...try/servicediscovery/service_discovery_registry.go 0.95% <0.00%> (-0.02%) ⬇️
registry/nacos/registry.go 42.51% <66.66%> (+0.44%) ⬆️
registry/directory/directory.go 73.49% <71.42%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 82e9849 into apache:feature-metrics Jul 31, 2023
6 checks passed
chickenlj added a commit that referenced this pull request Aug 4, 2023
* add metrics base api interface (#2350)

* Introduce metrics bus (#2351)

* add medata and config center metrics (#2357)

* add metadata rt metrics (#2363)

* add registry metrics (#2366)

---------

Co-authored-by: foghost <[email protected]>
Co-authored-by: finalt <[email protected]>
@FinalT FinalT deleted the rt1 branch August 5, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants