Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case #2973

Closed
2 tasks done
leihuazhe opened this issue Dec 16, 2018 · 3 comments
Closed
2 tasks done

CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case #2973

leihuazhe opened this issue Dec 16, 2018 · 3 comments

Comments

@leihuazhe
Copy link
Contributor

leihuazhe commented Dec 16, 2018 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: master
  • Operating System version: mac
  • Java version: 1.8

Steps to reproduce this issue

CallbackServiceCodec has a method referOrdestroyCallbackService,

I think it would be referOrDestroyCallbackService better ,so we can understand the method mean more simple.

Pls. provide [GitHub address] to reproduce this issue.
@leihuazhe leihuazhe mentioned this issue Dec 16, 2018
Closed
@leihuazhe
Copy link
Contributor Author

I just fix it ,and make a pull request number #2974

@leihuazhe leihuazhe mentioned this issue Dec 17, 2018
Merged
6 tasks
@leihuazhe
Copy link
Contributor Author

I take a pull request for it again which is #2979

beiwei30 pushed a commit that referenced this issue Dec 17, 2018
@leihuazhe @beiwei30
fix referOrDestroyCallbackService.referOrDestroyCallbackService to Ca…
fa41d6f 
…mel-case fix issues #2973 (#2979)
@leihuazhe
Copy link
Contributor Author

just fixed by #2979 , already merge to master ,so close this issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leihuazhe