Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallbackServiceCodec method Name Camel-Case Fix #2973 #2979

Merged
merged 1 commit into from
Dec 17, 2018
Merged

CallbackServiceCodec method Name Camel-Case Fix #2973 #2979

merged 1 commit into from
Dec 17, 2018

Conversation

leihuazhe
Copy link
Contributor

@leihuazhe leihuazhe commented Dec 17, 2018

…mel-case fix issues #2973

What is the purpose of the change

Pull request for fix the issues for #2973

change CallbackServiceCodec which method referOrdestroyCallbackService Name to referOrDestroyCallbackService

Brief changelog

incubator-dubbo/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@leihuazhe
Copy link
Contributor Author

take the pull request agin for fix issues #2973

@codecov-io
Copy link

Codecov Report

Merging #2979 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
+ Coverage   63.95%   63.98%   +0.02%     
==========================================
  Files         584      584              
  Lines       26059    26059              
  Branches     4562     4562              
==========================================
+ Hits        16666    16673       +7     
+ Misses       7217     7205      -12     
- Partials     2176     2181       +5
Impacted Files Coverage Δ
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 79.41% <100%> (+2.2%) ⬆️
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-2.18%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 60.62% <0%> (-1.75%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 56.06% <0%> (+0.37%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 81.95% <0%> (+0.75%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.66% <0%> (+0.83%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 69.79% <0%> (+2.01%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c558459...be4a40b. Read the comment docs.

@beiwei30
Copy link
Member

LGTM.

@beiwei30 beiwei30 merged commit fa41d6f into apache:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants