Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix When serialization fails, the code value in org.apache.dubbo.rpc.RpcException is set incorrectly. (#12279) #12280

Merged
merged 1 commit into from
May 17, 2023

Conversation

xuziyang
Copy link
Contributor

fix #12279

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can SerializationException just a type of RpcException

@xuziyang
Copy link
Contributor Author

Yes, is there any problem?

@xuziyang
Copy link
Contributor Author

RpcException

RpcException uses the internal code variable to indicate which type of exception has occurred. When a serialization exception occurs, the code value is set to NETWORK_EXCEPTION, which is incorrect. The correct value for code should be SERIALIZATION_EXCEPTION.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTL

@AlbumenJ
Copy link
Member

@CrazyHZM @chickenlj PTAL

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj closed this May 17, 2023
@chickenlj chickenlj reopened this May 17, 2023
@AlbumenJ AlbumenJ merged commit e1a7991 into apache:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants