Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialization RpcException bug pr rebase #12357

Merged
merged 18 commits into from
Jun 3, 2023
Merged

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented May 19, 2023

What is the purpose of the change

rebase #12280 because of merged by branch 2.7

@AlbumenJ
Copy link
Member

AlbumenJ commented May 20, 2023

[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    ExchangeCodecTest.testMessageLengthExceedPayloadLimitWhenEncode:515 expected: <25> but was: <50>
[INFO] 
Error:  Tests run: 377, Failures: 1, Errors: 0, Skipped: 8

Please fix uts

@AlbumenJ
Copy link
Member

How about change it to judge IOException? Let's standardize all exceptions thrown under Serialzation into IOException, and then unify catch IOException to judge whether it is serialization. In otherwise, such transform will discard some real network exception.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Merging #12357 (f42fd63) into 3.2 (08727e8) will increase coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12357      +/-   ##
============================================
+ Coverage     68.68%   69.28%   +0.59%     
+ Complexity      341        2     -339     
============================================
  Files          3569     1615    -1954     
  Lines        164820    66670   -98150     
  Branches      27335     9761   -17574     
============================================
- Hits         113204    46189   -67015     
+ Misses        41681    16021   -25660     
+ Partials       9935     4460    -5475     

see 2031 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wxbty
Copy link
Member Author

wxbty commented May 22, 2023

How about change it to judge IOException? Let's standardize all exceptions thrown under Serialzation into IOException, and then unify catch IOException to judge whether it is serialization. In otherwise, such transform will discard some real network exception.

PTAL again

wxbty and others added 2 commits May 29, 2023 19:41
…apache/dubbo/common/serialize/DefaultSerializationExceptionWrapper.java

Co-authored-by: Albumen Kevin <[email protected]>
@wxbty wxbty requested a review from AlbumenJ May 29, 2023 11:49
@wxbty wxbty requested a review from AlbumenJ June 2, 2023 07:24
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

6.1% 6.1% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 3d02e9c into apache:3.2 Jun 3, 2023
@wxbty wxbty deleted the seri_rebase branch June 3, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants