-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize LeastActiveLoadBalance select. #2161
Conversation
Now the select is select a random one when there are several least active invokers and all of them are in warm up. After this pr, it will select also by weight and warm up.
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
===========================================
+ Coverage 54.26% 54.3% +0.03%
- Complexity 5103 5110 +7
===========================================
Files 559 559
Lines 24947 24981 +34
Branches 4447 4453 +6
===========================================
+ Hits 13538 13565 +27
- Misses 9373 9381 +8
+ Partials 2036 2035 -1
Continue to review full report at Codecov.
|
Hi, Would you please add some unit test for this change? |
Now the select is select a random one when there are several least active invokers and all of them are in warm up. After this pr, it will select also by weight and warm up.
…to feature/optimize-leastactive
Sorry for rebase sth wrong into current branch, the new pr is here: |
Now the select is select a random one when there are several least active invokers and all of them are in warm up.
After this pr, it will select also by weight and warm up.
ISSUE:
#904