Core: Add comment property to ViewProperties #9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
changed the title
amogh-jahagirdar
force-pushed
the
view-comment-property
branch
from
c6f057c
to
e3732c8
Compare
amogh-jahagirdar
force-pushed
the
view-comment-property
branch
from
e3732c8
to
5f86df1
Compare
nastra
approved these changes
Dec 4, 2023
|
Thanks for the review @nastra , merging |
This was referenced Dec 11, 2023
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reference using "comment" as a property in the view spec, but it looks like we don't have a constant defined in the library. See trinodb/trino#19818 (comment) for more details but I think "comment" should be defined in the Iceberg library as it is not engine specific.