[OPPRO-308] Support SortMergeExec operator in Gluten with velox backend #554
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
JkSelf
force-pushed
the
add-smj-operator
branch
2 times, most recently
from
e24a076
to
f27197f
Compare
scalastyle-config.xml
Outdated
| @@ -94,7 +94,7 @@ This file is divided into 3 sections: | |||
| </check> | |||
|
|
|||
| <check customId="argcount" level="error" class="org.scalastyle.scalariform.ParameterNumberChecker" enabled="true"> | |||
| <parameters><parameter name="maxParameters"><![CDATA[10]]></parameter></parameters> | |||
There was a problem hiding this comment.
This setting is same with spark, if you change it, it will be hard work to merge to spark in the future.
If you really need more than 10 parameters, please use following instead. More prefer solutions is to obey the code style
// scalastyle off
// scalastyle on
There was a problem hiding this comment.
Thanks for your suggestions! Added scalastyle off and on for the parameters list.
JkSelf
force-pushed
the
add-smj-operator
branch
3 times, most recently
from
c675e8d
to
6bd052c
Compare
JkSelf
force-pushed
the
add-smj-operator
branch
3 times, most recently
from
9764c0e
to
607736c
Compare
gluten-core/src/main/scala/io/glutenproject/execution/SortMergeJoinExecTransformer.scala
Show resolved
Hide resolved
gluten-core/src/main/scala/io/glutenproject/execution/SortMergeJoinExecTransformer.scala
Show resolved
Hide resolved
JkSelf
force-pushed
the
add-smj-operator
branch
from
607736c
to
74a1cc6
Compare
ep/build-velox/src/get_velox.sh
Outdated
| VELOX_REPO=https://github.com/oap-project/velox.git | ||
| VELOX_BRANCH=main | ||
| VELOX_REPO=https://github.com/JkSelf/velox.git | ||
| VELOX_BRANCH=add-smj-operator |
There was a problem hiding this comment.
Would you like to open this PR to support SMJ?
There was a problem hiding this comment.
Filed PR#97 to support SMJ in velox.
There was a problem hiding this comment.
Velox branch could be changed back, thanks.
…n also reuse the common code
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)