Add smj support #97
Merged
Add smj support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
reviewed
Dec 14, 2022
| /// @param extension Substrait advanced extension. | ||
| /// @param config the key string of a config. | ||
| /// @return Whether the config is set as true. | ||
| bool configSetInOptimization( |
There was a problem hiding this comment.
How about moving this function into SubstraitParser so we can reuse here and there?
There was a problem hiding this comment.
Moved to SubstraitParser
rui-mo
approved these changes
Dec 14, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Dec 14, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Dec 14, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Dec 15, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Dec 15, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Dec 21, 2022
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jan 3, 2023
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Jan 11, 2023
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Jan 11, 2023
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Jan 31, 2023
zhejiangxiaomai
pushed a commit
that referenced
this pull request
Feb 22, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Feb 27, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 6, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 27, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 29, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 29, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 14, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 17, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 19, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.