-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Remove obsolete desktop modeler hub documentation #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have removed kogito modeler hub and desktop application while ago. - https://github.com/kiegroup/kie-tools/pull/706 - https://github.com/kiegroup/kie-tools/pull/1351 However we still have some references in the documentation. - https://docs.kogito.kie.org/latest/html_single/#con-kogito-modelers_kogito-creating-running
@kaldesai Could you please review this PR? |
kaldesai
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jomarko LGTM! Thank you!
Done! :) |
thank you for a review. @hmanwani-rh @kaldesai please merge, when you have a moment |
jomarko
referenced
this pull request
in jomarko/kie-docs
Aug 29, 2023
This PRs brings DMN docs changes introduced on main in 1H2023 - https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content) - https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR)
jomarko
referenced
this pull request
in jomarko/kie-docs
Aug 29, 2023
This PRs brings DMN docs changes introduced on main in 1H2023 - https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content) - https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR)
tarilabs
referenced
this pull request
Aug 29, 2023
* Update DMN related documentation on main-kogito This PRs brings DMN docs changes introduced on main in 1H2023 - https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content) - https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR) * Update doc-content/kogito-docs/src/main/asciidoc/creating-running/chap-kogito-creating-running.adoc Co-authored-by: Kalyani Desai <[email protected]> * Update doc-content/kogito-docs/src/main/asciidoc/dmn/chap-kogito-using-dmn-models.adoc Co-authored-by: Kalyani Desai <[email protected]> * Update doc-content/kogito-docs/src/main/asciidoc/dmn/chap-kogito-using-dmn-models.adoc Co-authored-by: Kalyani Desai <[email protected]> --------- Co-authored-by: Kalyani Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request
JIRA: (please edit the JIRA link if it exists)
link
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.