Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Remove obsolete desktop modeler hub documentation #4512

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Aug 16, 2023

We have removed kogito modeler hub and desktop application while ago.
- https://github.com/kiegroup/kie-tools/pull/706
- https://github.com/kiegroup/kie-tools/pull/1351

However we still have some references in the documentation.
- https://docs.kogito.kie.org/latest/html_single/#con-kogito-modelers_kogito-creating-running

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@hmanwani-rh
Copy link
Contributor

@kaldesai Could you please review this PR?

@hmanwani-rh hmanwani-rh removed their request for review August 16, 2023 12:27
Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko LGTM! Thank you!

@kaldesai
Copy link
Contributor

@kaldesai Could you please review this PR?

Done! :)

@jomarko
Copy link
Contributor Author

jomarko commented Aug 21, 2023

thank you for a review. @hmanwani-rh @kaldesai please merge, when you have a moment

@mareknovotny mareknovotny merged commit 490d73e into apache:main Aug 22, 2023
1 of 2 checks passed
jomarko referenced this pull request in jomarko/kie-docs Aug 29, 2023
This PRs brings DMN docs changes introduced on main in 1H2023
- https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content)
- https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR)
jomarko referenced this pull request in jomarko/kie-docs Aug 29, 2023
This PRs brings DMN docs changes introduced on main in 1H2023
- https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content)
- https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR)
tarilabs referenced this pull request Aug 29, 2023
* Update DMN related documentation on main-kogito

This PRs brings DMN docs changes introduced on main in 1H2023
- https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content)
- https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR)

* Update doc-content/kogito-docs/src/main/asciidoc/creating-running/chap-kogito-creating-running.adoc

Co-authored-by: Kalyani Desai <[email protected]>

* Update doc-content/kogito-docs/src/main/asciidoc/dmn/chap-kogito-using-dmn-models.adoc

Co-authored-by: Kalyani Desai <[email protected]>

* Update doc-content/kogito-docs/src/main/asciidoc/dmn/chap-kogito-using-dmn-models.adoc

Co-authored-by: Kalyani Desai <[email protected]>

---------

Co-authored-by: Kalyani Desai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants