optimize: remove mysql dependency from the distribution package (#6332)

apache · Feb 17, 2024 · f80a0fa · f80a0fa
1 parent 65610d0
commit f80a0fa
Show file tree

Hide file tree

Showing 9 changed files with 625 additions and 29 deletions.
diff --git a/changes/en-us/2.x.md b/changes/en-us/2.x.md
@@ -87,6 +87,7 @@ Add changes here for all PR submitted to the 2.x branch.
 - [[#6330](https://github.com/apache/incubator-seata/pull/6330)] remove mariadb API
 - [[#6329](https://github.com/apache/incubator-seata/pull/6312)] add saga subcomponent-level io.seata compatible api
 - [[#6254](https://github.com/apache/incubator-seata/pull/6254)] optimize Hessian Serialize
+- [[#6332](https://github.com/apache/incubator-seata/pull/6332)] remove mysql dependency from the distribution package
 - [[#6343](https://github.com/apache/incubator-seata/pull/6343)] compatible with tm module and rm-datasource module
 
 ### security:

diff --git a/changes/zh-cn/2.x.md b/changes/zh-cn/2.x.md
@@ -85,6 +85,7 @@
 - [[#6330](https://github.com/apache/incubator-seata/pull/6330)] 去除 mariadb API
 - [[#6329](https://github.com/apache/incubator-seata/pull/6312)] 添加saga子组件的io.seata兼容性API
 - [[#6254](https://github.com/apache/incubator-seata/pull/6254)] 优化Hessian 序列化
+- [[#6332](https://github.com/apache/incubator-seata/pull/6332)] 分发包中移除 mysql 依赖
 - [[#6343](https://github.com/apache/incubator-seata/pull/6343)] 兼容tm 模块和rm-datasource模块
 
 

diff --git a/core/src/main/java/org/apache/seata/core/store/db/AbstractDataSourceProvider.java b/core/src/main/java/org/apache/seata/core/store/db/AbstractDataSourceProvider.java
@@ -24,7 +24,9 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.stream.Stream;
+
 import javax.sql.DataSource;
+
 import org.apache.seata.common.exception.StoreException;
 import org.apache.seata.common.executor.Initialize;
 import org.apache.seata.common.util.ConfigTools;
@@ -78,11 +80,36 @@ public DataSource provide() {
         return this.dataSource;
     }
 
+    public DataSource generate() {
+        validate();
+        return doGenerate();
+    }
+
+    public void validate() {
+        //valid driver class name
+        String driverClassName = getDriverClassName();
+        ClassLoader loader = Thread.currentThread().getContextClassLoader();
+        if (null == loader) {
+            throw new StoreException("class loader set error, you should not use the Bootstrap classloader");
+        }
+        try {
+            loader.loadClass(driverClassName);
+        } catch (ClassNotFoundException exx) {
+            String driverClassPath = null;
+            String folderPath = System.getProperty("loader.path");
+            if (null != folderPath) {
+                driverClassPath = folderPath + "/jdbc/";
+            }
+            throw new StoreException(String.format(
+                "the {%s} can't be found in the path %s, please copy database driver dependencies, such as `mysql-connector-java.jar` to the path.", driverClassName, driverClassPath));
+        }
+
+    }
     /**
      * generate the datasource
      * @return datasource
      */
-    public abstract DataSource generate();
+    public abstract DataSource doGenerate();
 
     /**
      * Get db type db type.