Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove mysql dependency from the distribution package #6332

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Feb 5, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove mysql dependency from the distribution package

Ⅱ. Does this pull request fix one issue?

fix #6333

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added this to the 2.1.0 milestone Feb 5, 2024
@slievrly
Copy link
Member Author

slievrly commented Feb 5, 2024

image

@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (3e36de2) 51.97% compared to head (e3a2de0) 51.90%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6332      +/-   ##
============================================
- Coverage     51.97%   51.90%   -0.07%     
+ Complexity     5184     5183       -1     
============================================
  Files           921      921              
  Lines         32166    32181      +15     
  Branches       3874     3876       +2     
============================================
- Hits          16717    16703      -14     
- Misses        13814    13842      +28     
- Partials       1635     1636       +1     
Files Coverage Δ
...che/seata/server/store/DbcpDataSourceProvider.java 100.00% <ø> (ø)
...he/seata/server/store/DruidDataSourceProvider.java 100.00% <ø> (ø)
...e/seata/server/store/HikariDataSourceProvider.java 100.00% <ø> (ø)
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit f80a0fa into apache:2.x Feb 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Finished
Development

Successfully merging this pull request may close these issues.

remove mysql dependency from the distribution package
3 participants