Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix some tiny bugs #5332

Merged
merged 4 commits into from
Feb 12, 2023

Conversation

liuqiufeng
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5320

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

funky-eyes and others added 3 commits February 10, 2023 16:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #5332 (c0fee60) into develop (8a8310c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5332      +/-   ##
=============================================
- Coverage      48.80%   48.79%   -0.01%     
- Complexity      4175     4177       +2     
=============================================
  Files            743      743              
  Lines          26614    26614              
  Branches        3327     3326       -1     
=============================================
- Hits           12988    12986       -2     
- Misses         12222    12227       +5     
+ Partials        1404     1401       -3     
Impacted Files Coverage Δ
...va/io/seata/common/loader/ExtensionDefinition.java 38.70% <0.00%> (ø)
...ava/io/seata/common/util/LowerCaseLinkHashMap.java 0.00% <0.00%> (ø)
...o/seata/server/session/AbstractSessionManager.java 61.19% <0.00%> (-2.99%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 48.23% <0.00%> (-2.36%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️
...er/src/main/java/io/seata/server/ServerRunner.java 65.38% <0.00%> (+15.38%) ⬆️

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 04fac86 into apache:develop Feb 12, 2023
@funky-eyes funky-eyes added this to the 1.7.0 milestone Feb 12, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/common common module labels Feb 12, 2023
l81893521 pushed a commit to l81893521/seata that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/common common module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants