-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix some tiny bugs #5332
bugfix: fix some tiny bugs #5332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…evelop_bug_fix_20230210 # Conflicts: # changes/en-us/develop.md # changes/zh-cn/develop.md
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5332 +/- ##
=============================================
- Coverage 48.80% 48.79% -0.01%
- Complexity 4175 4177 +2
=============================================
Files 743 743
Lines 26614 26614
Branches 3327 3326 -1
=============================================
- Hits 12988 12986 -2
- Misses 12222 12227 +5
+ Partials 1404 1401 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5320
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews