Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix some tiny bugs #5332

Merged
merged 4 commits into from
Feb 12, 2023
Merged

bugfix: fix some tiny bugs #5332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ca547e
bugfix: fix some tiny bugs
liuqiufeng Feb 10, 2023
50a709f
Merge branch 'develop' into develop_bug_fix_20230210
funky-eyes Feb 10, 2023
8aeab6e
develop.md
liuqiufeng Feb 10, 2023
c0fee60
Merge remote-tracking branch 'origin/develop_bug_fix_20230210' into d…
liuqiufeng Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changes/en-us/develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Add changes here for all PR submitted to the develop branch.
- [[#5307](https://github.com/seata/seata/pull/5307)] fix that keywords don't add escaped characters
- [[#5311](https://github.com/seata/seata/pull/5311)] remove RollbackRetryTimeout sessions during in file storage recover
- [[#5316](https://github.com/seata/seata/pull/5316)] fix G1 jvm parameter in jdk8

- [[#5332](https://github.com/seata/seata/pull/5332)] fix bugs found in unit tests

### optimize:
- [[#5208](https://github.com/seata/seata/pull/5208)] optimize throwable getCause once more
Expand Down Expand Up @@ -60,6 +60,7 @@ Thanks to these contributors for their code commits. Please report an unintended
- [ZhangShiYeChina](https://github.com/ZhangShiYeChina)
- [mxsm](https://github.com/mxsm)
- [l81893521](https://github.com/l81893521)
- [liuqiufeng](https://github.com/liuqiufeng)


Also, we receive many valuable issues, questions and advices from our community. Thanks for you all.
2 changes: 2 additions & 0 deletions changes/zh-cn/develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- [[#5307](https://github.com/seata/seata/pull/5307)] 修复生成update前后镜像sql不对关键字转义的bug
- [[#5311](https://github.com/seata/seata/pull/5311)] 移除基于文件存储恢复时的RollbackRetryTimeout事务
- [[#5316](https://github.com/seata/seata/pull/5316)] 修复jdk8 中 G1 参数
- [[#5332](https://github.com/seata/seata/pull/5332)] 修复单元测试中发现的bug

### optimize:
- [[#5208](https://github.com/seata/seata/pull/5208)] 优化多次重复获取Throwable#getCause问题
Expand Down Expand Up @@ -59,6 +60,7 @@
- [ZhangShiYeChina](https://github.com/ZhangShiYeChina)
- [mxsm](https://github.com/mxsm)
- [l81893521](https://github.com/l81893521)
- [liuqiufeng](https://github.com/liuqiufeng)


同时，我们收到了社区反馈的很多有价值的issue和建议，非常感谢大家。
2 changes: 1 addition & 1 deletion common/src/main/java/io/seata/common/loader/ExtensionDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public boolean equals(Object obj) {
if (!order.equals(other.order)) {
return false;
}
return !scope.equals(other.scope);
return scope.equals(other.scope);
}

public String getName() {
Expand Down
2 changes: 1 addition & 1 deletion common/src/main/java/io/seata/common/util/LowerCaseLinkHashMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public boolean containsKey(Object o) {

@Override
public boolean containsValue(Object o) {
return targetMap.containsKey(o);
return targetMap.containsValue(o);
}

@Override
Expand Down