optimize: using namespace from command line when deployment with helm charts #6029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
-n
parameter in thehelm install
command, but currently, deployment ignores the namespace specified in the command line.so in this PR:
namespace
has been removed from values.yaml.{{ .Release.Namespace }}
.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
I confirmed the correctness of the execution result through
helm template --dry-run
.Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews